-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] - Add copy command #1044
Open
Prajjwal
wants to merge
1
commit into
ruby:master
Choose a base branch
from
Shopify:sin.add-copy-command
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'mkmf' | ||
|
||
module IRB | ||
module Command | ||
class Copy < Base | ||
category "TODO" | ||
description "TODO" | ||
|
||
help_message(<<~HELP) | ||
Usage: copy (input) | ||
HELP | ||
|
||
def execute(arg) | ||
output = irb_context.workspace.binding.eval(arg) | ||
|
||
if clipboard_available? | ||
copy_to_clipboard(output) | ||
puts "Copied to system clipboard" | ||
else | ||
temp_file = write_to_tempfile(output) | ||
puts "Wrote: #{temp_file}" | ||
end | ||
rescue StandardError => e | ||
warn "Error: #{e}" | ||
end | ||
|
||
private | ||
|
||
def copy_to_clipboard(text) | ||
IO.popen(clipboard, 'w') do |io| | ||
io.write(text) | ||
end | ||
|
||
raise "IOError" unless $? == 0 | ||
end | ||
|
||
def write_to_tempfile(text) | ||
file = Tempfile.new | ||
file.write(text) | ||
file.close | ||
file.path | ||
end | ||
|
||
def clipboard | ||
case RbConfig::CONFIG['host_os'] | ||
when /darwin/ | ||
# This is the most reliable method, but we could probably also offload this | ||
# to the shell to avoid MkMf logs | ||
MakeMakefile.find_executable('pbcopy') | ||
when /linux/ | ||
MakeMakefile.find_executable('xclip').tap do |path| | ||
path << '-selection clipboard' | ||
end | ||
when /mswin|mingw/ | ||
'clip' # => todo verify this works | ||
else | ||
nil | ||
end | ||
end | ||
|
||
def clipboard_available? | ||
!!clipboard | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to apply the output inspection method here so the copied output will be closer to what the users may expect.
For example, the
output
here by default will be theto_s
result of the evaluation result, but IRB's default output inspector pretty prints the result inspect.Additionally, we need to make sure colorizing is NOT applied to the copied value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with using the pretty printer is that colorizing output is hardcoded into it, and I don't think we want it in our clipboard.
Unless there's a pretty printer that I've missed, the options are:
color_printer.rb
to accept a parameter that turns colorizing on / off. Most invasive.I like 1, but will defer.