Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rubocop check to activesupport #759

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Dec 26, 2024

This change allows rubocop to perform style checks on changes to activesupport.

  • Update rubocop-on-rbs v1.3.0
  • Add .rubocop.yml to activesupport
  • Apply rubocop -a
rubocop log
Offenses:

gems/activesupport/6.0/activesupport-generated.rbs:224:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:75: C: [Corrected] RBS/Style/RedundantParentheses: Don't use parentheses around simple type.
      def write_entry: (untyped key, untyped entry, **untyped options) -> (bool)
                                                                          ^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:76: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> (::FalseClass | ::TrueClass)
                                                                           ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:76: C: [Corrected] RBS/Style/TrueFalse: Use bool instead of ::FalseClass | ::TrueClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> (::FalseClass | ::TrueClass)
                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:76: C: [Corrected] RBS/Style/TrueFalse: Use bool instead of false | true
      def write_entry: (untyped key, untyped entry, **untyped options) -> (false | true)
                                                                           ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:91: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> (::FalseClass | ::TrueClass)
                                                                                          ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:298:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:378:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:414:76: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> (::FalseClass | untyped)
                                                                           ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:434:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:450:75: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> ::TrueClass
                                                                          ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:452:61: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
      def delete_entry: (untyped key, **untyped options) -> ::FalseClass
                                                            ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:491:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:670:79: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
          def write_entry: (untyped key, untyped value, **untyped options) -> ::TrueClass
                                                                              ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:795:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:795:5: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless private access modifier.
    private
    ^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:803:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:803:5: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless public access modifier.
    public
    ^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2173:30: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_date?: () -> ::TrueClass
                             ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2183:21: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def blank?: () -> ::FalseClass
                    ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2594:30: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_date?: () -> ::TrueClass
                             ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2597:30: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_time?: () -> ::TrueClass
                             ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2607:21: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def blank?: () -> ::FalseClass
                    ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:4297:26: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def duplicable?: () -> ::TrueClass
                         ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:4305:26: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def duplicable?: () -> ::FalseClass
                         ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:4313:26: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def duplicable?: () -> ::FalseClass
                         ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:4768:32: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_string?: () -> ::TrueClass
                               ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5081:25: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def html_safe?: () -> ::FalseClass
                        ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5085:25: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def html_safe?: () -> ::TrueClass
                        ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5192:30: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_time?: () -> ::TrueClass
                             ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5725:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:5726:7: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless private access modifier.
      private
      ^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5970:41: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
    def autoloaded?: (untyped desc) -> (::FalseClass | untyped)
                                        ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:6488:28: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def validate!: () -> ::TrueClass
                           ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:7099:37: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
    def extractable_options?: () -> ::TrueClass
                                    ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:7909:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:7911:5: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless private access modifier.
    private
    ^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:9003:49: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
          def subscribed_to?: (untyped name) -> ::TrueClass
                                                ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:9005:35: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
          def unsubscribe!: () -> ::FalseClass
                                  ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:9913:37: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
    def extractable_options?: () -> ::TrueClass
                                    ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11157:32: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
    def acts_like_time?: () -> ::TrueClass
                               ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11165:23: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
    def blank?: () -> ::FalseClass
                      ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11175:60: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
    def respond_to?: (untyped sym, ?bool include_priv) -> (::FalseClass | untyped)
                                                           ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11179:70: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
    def respond_to_missing?: (untyped sym, untyped include_priv) -> (::FalseClass | untyped)
                                                                     ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11803:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:11806:3: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless public access modifier.
  public
  ^^^^^^
gems/activesupport/6.0/activesupport.rbs:237:28: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
                           | (Numeric arg0) -> self
                           ^
gems/activesupport/6.0/activesupport.rbs:239:28: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
                           | (Numeric arg0) -> self
                           ^
gems/activesupport/6.0/activesupport.rbs:384:1: C: [Corrected] RBS/Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
    def try: () { (untyped) -> untyped } -> nil
^^^^
gems/activesupport/6.0/activesupport.rbs:385:12: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
           | () { () -> untyped } -> nil
           ^
gems/activesupport/6.0/activesupport.rbs:386:12: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
           | (Object::name method_name, *untyped args) ?{ (*untyped) -> untyped } -> nil
           ^
gems/activesupport/6.0/activesupport.rbs:388:1: C: [Corrected] RBS/Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
    def try!: () { (untyped) -> untyped } -> nil
^^^^
gems/activesupport/6.0/activesupport.rbs:389:13: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
            | () { () -> untyped } -> nil
            ^
gems/activesupport/6.0/activesupport.rbs:390:13: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
            | (Object::name method_name, *untyped args) ?{ (*untyped) -> untyped } -> nil
            ^
gems/activesupport/6.0/activesupport.rbs:391:1: C: [Corrected] RBS/Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.

ksss added 3 commits December 25, 2024 10:56
Offenses:

gems/activesupport/6.0/activesupport-generated.rbs:224:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:75: C: [Corrected] RBS/Style/RedundantParentheses: Don't use parentheses around simple type.
      def write_entry: (untyped key, untyped entry, **untyped options) -> (bool)
                                                                          ^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:76: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> (::FalseClass | ::TrueClass)
                                                                           ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:76: C: [Corrected] RBS/Style/TrueFalse: Use bool instead of ::FalseClass | ::TrueClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> (::FalseClass | ::TrueClass)
                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:76: C: [Corrected] RBS/Style/TrueFalse: Use bool instead of false | true
      def write_entry: (untyped key, untyped entry, **untyped options) -> (false | true)
                                                                           ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:248:91: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> (::FalseClass | ::TrueClass)
                                                                                          ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:298:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:378:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:414:76: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> (::FalseClass | untyped)
                                                                           ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:434:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:450:75: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def write_entry: (untyped key, untyped entry, **untyped options) -> ::TrueClass
                                                                          ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:452:61: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
      def delete_entry: (untyped key, **untyped options) -> ::FalseClass
                                                            ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:491:50: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def self.supports_cache_versioning?: () -> ::TrueClass
                                                 ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:670:79: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
          def write_entry: (untyped key, untyped value, **untyped options) -> ::TrueClass
                                                                              ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:795:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:795:5: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless private access modifier.
    private
    ^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:803:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:803:5: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless public access modifier.
    public
    ^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2173:30: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_date?: () -> ::TrueClass
                             ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2183:21: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def blank?: () -> ::FalseClass
                    ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2594:30: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_date?: () -> ::TrueClass
                             ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2597:30: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_time?: () -> ::TrueClass
                             ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:2607:21: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def blank?: () -> ::FalseClass
                    ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:4297:26: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def duplicable?: () -> ::TrueClass
                         ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:4305:26: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def duplicable?: () -> ::FalseClass
                         ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:4313:26: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def duplicable?: () -> ::FalseClass
                         ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:4768:32: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_string?: () -> ::TrueClass
                               ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5081:25: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
  def html_safe?: () -> ::FalseClass
                        ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5085:25: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def html_safe?: () -> ::TrueClass
                        ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5192:30: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
  def acts_like_time?: () -> ::TrueClass
                             ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5725:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:5726:7: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless private access modifier.
      private
      ^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:5970:41: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
    def autoloaded?: (untyped desc) -> (::FalseClass | untyped)
                                        ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:6488:28: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
      def validate!: () -> ::TrueClass
                           ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:7099:37: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
    def extractable_options?: () -> ::TrueClass
                                    ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:7909:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:7911:5: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless private access modifier.
    private
    ^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:9003:49: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
          def subscribed_to?: (untyped name) -> ::TrueClass
                                                ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:9005:35: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
          def unsubscribe!: () -> ::FalseClass
                                  ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:9913:37: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
    def extractable_options?: () -> ::TrueClass
                                    ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11157:32: C: [Corrected] RBS/Style/ClassicType: Use true instead of ::TrueClass
    def acts_like_time?: () -> ::TrueClass
                               ^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11165:23: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
    def blank?: () -> ::FalseClass
                      ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11175:60: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
    def respond_to?: (untyped sym, ?bool include_priv) -> (::FalseClass | untyped)
                                                           ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11179:70: C: [Corrected] RBS/Style/ClassicType: Use false instead of ::FalseClass
    def respond_to_missing?: (untyped sym, untyped include_priv) -> (::FalseClass | untyped)
                                                                     ^^^^^^^^^^^^
gems/activesupport/6.0/activesupport-generated.rbs:11803:1: C: [Corrected] RBS/Layout/EmptyLines: Extra blank line detected.
gems/activesupport/6.0/activesupport-generated.rbs:11806:3: W: [Corrected] RBS/Lint/UselessAccessModifier: Useless public access modifier.
  public
  ^^^^^^
gems/activesupport/6.0/activesupport.rbs:237:28: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
                           | (Numeric arg0) -> self
                           ^
gems/activesupport/6.0/activesupport.rbs:239:28: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
                           | (Numeric arg0) -> self
                           ^
gems/activesupport/6.0/activesupport.rbs:384:1: C: [Corrected] RBS/Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
    def try: () { (untyped) -> untyped } -> nil
^^^^
gems/activesupport/6.0/activesupport.rbs:385:12: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
           | () { () -> untyped } -> nil
           ^
gems/activesupport/6.0/activesupport.rbs:386:12: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
           | (Object::name method_name, *untyped args) ?{ (*untyped) -> untyped } -> nil
           ^
gems/activesupport/6.0/activesupport.rbs:388:1: C: [Corrected] RBS/Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
    def try!: () { (untyped) -> untyped } -> nil
^^^^
gems/activesupport/6.0/activesupport.rbs:389:13: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
            | () { () -> untyped } -> nil
            ^
gems/activesupport/6.0/activesupport.rbs:390:13: C: [Corrected] RBS/Layout/OverloadIndentation: Indent the | to the first :
            | (Object::name method_name, *untyped args) ?{ (*untyped) -> untyped } -> nil
            ^
gems/activesupport/6.0/activesupport.rbs:391:1: C: [Corrected] RBS/Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
Copy link

@ksss Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activesupport

You changed RBS files for an existing gem.
You can merge this PR yourself because you are a reviewer of this gem.
Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.


You changed non-gem files.

@pocke, please review and approve the changes.

@ksss ksss requested a review from pocke December 27, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant