-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activestorage: Add ActiveStorage::Current #702
Conversation
@tk0miya Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
3121220
to
b63a36c
Compare
refs: * https://github.com/rails/rails/blob/v6.0.6.1/activestorage/app/models/active_storage/current.rb * https://github.com/rails/rails/blob/v7.0.8.6/activestorage/app/models/active_storage/current.rb * `#url_options` has been added and `#host` has been deprecated
b63a36c
to
a9ad39f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVE
/merge |
Thanks! |
The type of ActiveStorage::Current is now registered to gem_rbs_collection. And the type of #preload of active record models is also fixed. * ruby/gem_rbs_collection#702 * ruby/gem_rbs_collection#700
The type of ActiveStorage::Current is now registered to gem_rbs_collection. And the type of #preload of active record models is also fixed. * ruby/gem_rbs_collection#702 * ruby/gem_rbs_collection#700
This contains #701.
refs:
#url_options
has been added and#host
has been deprecated