Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signeture of Faraday::Connection#options #672

Merged

Conversation

rhiroe
Copy link
Contributor

@rhiroe rhiroe commented Sep 24, 2024

Add Faraday::Connection#options signature and Faraday::RequestOptions class.

After merging this Pull Request, the following code passes type checking.

conn = Faraday.new do |builder|
  builder.options.open_timeout = 5
  builder.options.read_timeout = 10
  builder.options.write_timeout = 5
end

Copy link

@rhiroe Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

faraday

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@yykamei, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

@rhiroe rhiroe closed this Sep 24, 2024
@rhiroe rhiroe force-pushed the Add-signeture-of-Faraday--Connection#options branch from 4451896 to f7684ee Compare September 24, 2024 03:52
@rhiroe rhiroe reopened this Sep 24, 2024
@rhiroe rhiroe force-pushed the Add-signeture-of-Faraday--Connection#options branch from 5598010 to 4ad3bb4 Compare September 24, 2024 04:04
@rhiroe rhiroe force-pushed the Add-signeture-of-Faraday--Connection#options branch from 4ad3bb4 to 259f4fe Compare September 24, 2024 04:04
@yykamei
Copy link
Contributor

yykamei commented Sep 24, 2024

APPROVE

@yykamei
Copy link
Contributor

yykamei commented Sep 24, 2024

Thank you!

@yykamei
Copy link
Contributor

yykamei commented Sep 24, 2024

/merge

Copy link

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers.

See the Actions tab for detail.

Copy link
Contributor

@yykamei yykamei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@yykamei
Copy link
Contributor

yykamei commented Sep 24, 2024

/merge

Copy link

Thanks for your review, @yykamei!

@rhiroe, @yykamei This PR is ready to be merged.
Just comment /merge to merge this PR.

@github-actions github-actions bot merged commit 92705dd into ruby:main Sep 24, 2024
4 checks passed
@rhiroe rhiroe deleted the Add-signeture-of-Faraday--Connection#options branch September 24, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants