Fix help message of the eval command
#1130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the `eval` command (or its alias, `call`) without an argument, you get the following error: ``` [REPL ERROR] #<NameError: undefined local variable or method `cmd' for #<DEBUGGER__::Session:0x0000000120a0fa20>> debug-1.10.0/lib/debug/session.rb:934:in `block in register_default_command' debug-1.10.0/lib/debug/session.rb:1165:in `process_command' ... ``` ...instead of this hint: ``` To evaluate the variable `eval`, use `pp eval` instead. ``` I believe the regression was introduced in a402e73. To fix this issue, I was thinking of passing the command name alongside the argument in the `process_line` method but I wasn't sure this was worth it just for this hint. So I removed the hint altogether instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
evalcommand (or its alias,call) without an argument, you get the following error:...instead of this hint:
I believe the regression was introduced in a402e73.
To fix this issue, I was thinking of passing the command name alongside the argument in the
process_linemethod but I wasn't sure this was worth it just for this hint. So I removed the hint altogether instead.