Fix irb_test prompt assertion failure #1100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changing IRB's behavior with TERM=dumb in ruby/irb#907,
test_irb_command_switches_console_to_irb
andtest_irb_console_config_activates_irb
began failing. This pull request fixes it.With a workaround ruby/irb#943, test does not fail now.
Description
As described in
def assert_raw_line_text
comment, assert_line_text is not suitable for testing IRB's prompt.The test was passing before because Reline prints redundant output when TERM is set to dumb, which was problematic while running IRB in emacs shell.