Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make irb_console toggleable with config update #1057

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jan 2, 2024

  1. When the user sets irb_console to true through the command, the irb:rdbg will now be enabled the same way as typing the irb command.
  2. When the user sets irb_console to false through the command, the irb:rdbg will now be disabled.
  3. Users can now enable irb:rdbg by setting irb_console to true in their .rdbgrc file.

Copy link

@joe-sharp joe-sharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed you had this open PR when I filed my issue! Thanks for the fix!

@st0012 st0012 force-pushed the make-irb-rdbg-reversable branch from 55d6f2c to e7e4d63 Compare February 8, 2024 13:01
@ko1 ko1 enabled auto-merge (rebase) February 20, 2024 09:55
1. When the user sets `irb_console` to `true` through the command, the
   `irb:rdbg` will now be enabled the same way as typing the `irb` command.
2. When the user sets `irb_console` to `false` through the command, the
   `irb:rdbg` will now be disabled.
3. Users can now enable `irb:rdbg` by setting `irb_console` to `true` in
   their `.rdbgrc` file.
auto-merge was automatically disabled February 21, 2024 12:49

Head branch was pushed to by a user without write access

@st0012 st0012 force-pushed the make-irb-rdbg-reversable branch from e7e4d63 to 46b8ea0 Compare February 21, 2024 12:49
@ko1 ko1 merged commit 68f7753 into ruby:master Feb 21, 2024
26 of 28 checks passed
@st0012 st0012 deleted the make-irb-rdbg-reversable branch February 21, 2024 13:02
@jhirn
Copy link

jhirn commented Mar 29, 2024

Have a question not worth opening up a new issue for. When running bin/rspec ... or bin/rails ... it does not seem to automatically pickup the .rdbgrc config when I just use binding.break in a file. Is there something else I have to do in my project to ensure debug gem picks up this config when setting a break point?

xjunior referenced this pull request in powerhome/audiences Apr 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [debug](https://togithub.com/ruby/debug) | `1.9.1` -> `1.9.2` |
[![age](https://developer.mend.io/api/mc/badges/age/rubygems/debug/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/debug/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/debug/1.9.1/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/debug/1.9.1/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ruby/debug (debug)</summary>

### [`v1.9.2`](https://togithub.com/ruby/debug/releases/tag/v1.9.2)

[Compare
Source](https://togithub.com/ruby/debug/compare/v1.9.1...v1.9.2)

#### What's Changed

-   config
- Make irb_console toggleable with config update by
[@&#8203;st0012](https://togithub.com/st0012) in
[https://github.com/ruby/debug/pull/1057](https://togithub.com/ruby/debug/pull/1057)
-   internal
- Stop assuming Array#each is written in C by
[@&#8203;k0kubun](https://togithub.com/k0kubun) in
[https://github.com/ruby/debug/pull/1061](https://togithub.com/ruby/debug/pull/1061)
- Add `base64` gem to the dependencies by
[@&#8203;y-yagi](https://togithub.com/y-yagi) in
[https://github.com/ruby/debug/pull/1066](https://togithub.com/ruby/debug/pull/1066)
- Support Ruby 3.4's new error message format by
[@&#8203;hsbt](https://togithub.com/hsbt) in
[https://github.com/ruby/debug/pull/1080](https://togithub.com/ruby/debug/pull/1080)
- catch up ruby 3.4.0 error related changes by
[@&#8203;ko1](https://togithub.com/ko1) in
[https://github.com/ruby/debug/pull/1083](https://togithub.com/ruby/debug/pull/1083)
- Fix syntax warnings by
[@&#8203;casperisfine](https://togithub.com/casperisfine) in
[https://github.com/ruby/debug/pull/1072](https://togithub.com/ruby/debug/pull/1072)
- Drop base64 dependency by
[@&#8203;Earlopain](https://togithub.com/Earlopain) in
[https://github.com/ruby/debug/pull/1071](https://togithub.com/ruby/debug/pull/1071)
- Fix ENOENT error when readline is not loaded by
[@&#8203;lazyatom](https://togithub.com/lazyatom) in
[https://github.com/ruby/debug/pull/1073](https://togithub.com/ruby/debug/pull/1073)
- Remove and Restore irb configuration like irbrc while irb console
tests by [@&#8203;hsbt](https://togithub.com/hsbt) in
[https://github.com/ruby/debug/pull/1067](https://togithub.com/ruby/debug/pull/1067)
- Use rb_iseqw_to_iseq to get iseq pointer by
[@&#8203;peterzhu2118](https://togithub.com/peterzhu2118) in
[https://github.com/ruby/debug/pull/1093](https://togithub.com/ruby/debug/pull/1093)
-   tests
- Add Ruby 3.3 to CI matrix by
[@&#8203;st0012](https://togithub.com/st0012) in
[https://github.com/ruby/debug/pull/1058](https://togithub.com/ruby/debug/pull/1058)
- Use ruby/actions workflow for ruby versions by
[@&#8203;m-nakamura145](https://togithub.com/m-nakamura145) in
[https://github.com/ruby/debug/pull/1065](https://togithub.com/ruby/debug/pull/1065)
- Separate setup and execution steps in CI by
[@&#8203;ono-max](https://togithub.com/ono-max) in
[https://github.com/ruby/debug/pull/1088](https://togithub.com/ruby/debug/pull/1088)
- Fix flakey test "test_reponse_returns_correct_threads_info" by
[@&#8203;ono-max](https://togithub.com/ono-max) in
[https://github.com/ruby/debug/pull/1089](https://togithub.com/ruby/debug/pull/1089)
- Add Launchable in CI by
[@&#8203;ono-max](https://togithub.com/ono-max) in
[https://github.com/ruby/debug/pull/1090](https://togithub.com/ruby/debug/pull/1090)
-   doc
- Correct the irb command's description by
[@&#8203;st0012](https://togithub.com/st0012) in
[https://github.com/ruby/debug/pull/1056](https://togithub.com/ruby/debug/pull/1056)
- Fix prelude doc example to use curly braces by
[@&#8203;adam12](https://togithub.com/adam12) in
[https://github.com/ruby/debug/pull/1052](https://togithub.com/ruby/debug/pull/1052)
- Mention IRB console in readme by
[@&#8203;st0012](https://togithub.com/st0012) in
[https://github.com/ruby/debug/pull/1092](https://togithub.com/ruby/debug/pull/1092)

#### New Contributors

- [@&#8203;Earlopain](https://togithub.com/Earlopain) made their first
contribution in
[https://github.com/ruby/debug/pull/1071](https://togithub.com/ruby/debug/pull/1071)
- [@&#8203;lazyatom](https://togithub.com/lazyatom) made their first
contribution in
[https://github.com/ruby/debug/pull/1073](https://togithub.com/ruby/debug/pull/1073)
- [@&#8203;m-nakamura145](https://togithub.com/m-nakamura145) made their
first contribution in
[https://github.com/ruby/debug/pull/1065](https://togithub.com/ruby/debug/pull/1065)

**Full Changelog**:
ruby/debug@v1.9.1...v1.9.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/powerhome/audiences).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants