Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on Ubuntu 20.04 #210

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Oct 18, 2024

Compilation currently fails with GCC 9.

/home/runner/work/torch.rb/torch.rb/vendor/bundle/ruby/3.1.0/gems/rice-4.3.2/include/rice/rice.hpp:1141:109:   required from here
/usr/include/c++/9/type_traits:131:12: error: incomplete type ‘std::is_copy_constructible<std::_Tuple_impl<2, std::any> >’ used in nested name specifier

Ref: https://stackoverflow.com/questions/65163455/stdany-containing-stdtuplestdany-fails-to-compile

@jasonroelofs
Copy link
Collaborator

👍

@jasonroelofs jasonroelofs merged commit 6b910e1 into ruby-rice:master Oct 19, 2024
12 of 13 checks passed
@ankane
Copy link
Contributor Author

ankane commented Oct 19, 2024

Thanks

@cfis
Copy link
Collaborator

cfis commented Oct 20, 2024

That looks like a nice improvement - thanks!

@jasonroelofs
Copy link
Collaborator

Version 4.3.3 is pushed with this fix.

@ankane
Copy link
Contributor Author

ankane commented Oct 22, 2024

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants