Better handle LoadErrors from prism
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Dec 28, 2024
koic
reviewed
Dec 28, 2024
koic
reviewed
Dec 28, 2024
koic
reviewed
Dec 28, 2024
koic
reviewed
Dec 28, 2024
koic
reviewed
Dec 28, 2024
koic
reviewed
Dec 28, 2024
koic
reviewed
Dec 28, 2024
koic
reviewed
Dec 28, 2024
There are two different cases that may happen: 1: Prism is compiled in the past, the user updated the ruby version, but it still points to the same library > linked to incompatible /home/earlopain/.rbenv/versions/3.4.1/lib/libruby.so.3.4 - /home/earlopain/Documents/ruby-prism/lib/prism/prism.so In that case, bubble up the original error. On the other hand, since prism is no dependency, users may run older verions that are missing translator classes. In that case, show a message what they should do. prism is a default gem since 3.3, so you can even use it without adding it to your gemfile.
Earlopain
force-pushed
the
prism-load-errors
branch
from
bffc8ed to
35790c4
Compare
|
Thanks, I think I've applied all your suggestions |
koic
reviewed
Dec 28, 2024
Co-authored-by: Koichi ITO <[email protected]>
|
Thanks to both of you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different cases that may happen:
Prism was compiled in the past, the user updated the ruby version, but it still points to the same library
In that case, bubble up the original error.
On the other hand, since prism is no dependency, users may run older verions that are missing translator classes. In that case, show a message what they should do.
prism is a default gem since 3.3, so you can even use it without adding it to your gemfile.