Add BlockNode#{first,last}_argument
helpers
#270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods allow more consistent use of
first_argument
andlast_argument
across more node types.The motivation for this PR is to allow for an
InternalAffairs/NodeFirstArgument
cop to enforcenode.arguments.first
andnode.arguments[0]
be replaced withnode.first_argument
. For this to be possible, we need to extendfirst_argument
to other node types, since the cop can't statically know what the node type is to determine if the method exists or not.