Refactor ArrayNode#percent_literal?

rubocop · Dec 13, 2024 · 4529384 · 4529384
1 parent e4a84a4
commit 4529384
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/lib/rubocop/ast/node/array_node.rb b/lib/rubocop/ast/node/array_node.rb
@@ -7,8 +7,8 @@ module AST
     # to all `array` nodes within RuboCop.
     class ArrayNode < Node
       PERCENT_LITERAL_TYPES = {
-        string: /^%[wW]/,
-        symbol: /^%[iI]/
+        string: /\A%[wW]/,
+        symbol: /\A%[iI]/
       }.freeze
       private_constant :PERCENT_LITERAL_TYPES
 
@@ -50,7 +50,7 @@ def square_brackets?
       # @return [Boolean] whether the array is enclosed in percent brackets
       def percent_literal?(type = nil)
         if type
-          loc.begin && loc.begin.source =~ PERCENT_LITERAL_TYPES[type]
+          loc.begin&.source&.match?(PERCENT_LITERAL_TYPES.fetch(type))
         else
           loc.begin&.source&.start_with?('%')
         end

diff --git a/lib/rubocop/ast/node/str_node.rb b/lib/rubocop/ast/node/str_node.rb
@@ -13,6 +13,7 @@ class StrNode < Node
         :q => /\A%q/,
         :Q => /\A%Q/
       }.freeze
+      private_constant :PERCENT_LITERAL_TYPES
 
       def single_quoted?
         loc_is?(:begin, "'")

diff --git a/spec/rubocop/ast/array_node_spec.rb b/spec/rubocop/ast/array_node_spec.rb
@@ -88,6 +88,14 @@
       it { is_expected.not_to be_percent_literal(:string) }
       it { is_expected.to be_percent_literal(:symbol) }
     end
+
+    context 'with an invalid type' do
+      let(:source) { '%i(foo bar)' }
+
+      it 'raises KeyError' do
+        expect { array_node.percent_literal?(:foo) }.to raise_error(KeyError, 'key not found: :foo')
+      end
+    end
   end
 
   describe '#bracketed?' do