Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starting to rate #43

Closed
wants to merge 2 commits into from
Closed

starting to rate #43

wants to merge 2 commits into from

Conversation

Tridentinus
Copy link
Collaborator

No description provided.

rtjord
rtjord requested changes Nov 13, 2024
View reviewed changes
Copy link
Owner

@rtjord rtjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove your profile from the samconfig.toml file so the automatic deployment works

backend/samconfig.toml Outdated Show resolved Hide resolved
backend/src/handlers/PackageCreate/index.ts Show resolved Hide resolved
@Tridentinus Tridentinus requested a review from rtjord November 14, 2024 03:14
rtjord
rtjord previously approved these changes Nov 14, 2024
View reviewed changes
@rtjord rtjord dismissed their stale review November 16, 2024 05:06

Rating is only required for cases where the URL is provided

rtjord
rtjord reviewed Nov 16, 2024
View reviewed changes
Copy link
Owner

@rtjord rtjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Piazza, Professor Davis said we don't have to rate a packages that are uploaded by ACME employees. We only have to rate packages where the npm url is provided

@rtjord rtjord closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtjord rtjord rtjord left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tridentinus @rtjord