Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add transcoded url meta #296

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

pranvinit
Copy link

Types of changes

What types of changes does your code introduced to project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Details

  1. Add a _rt_transcoded_url meta field to the attachment to save the transcoded URL.
  2. Add an editable URL form field in the media modal.
  3. Add a toggle to set Adaptive Bitrate Streaming in the transcoder settings page.
  4. WIP: Progress bar functionality.

Checklist

Put an x in the boxes that apply.

  • Lint and tests pass locally with my changes
  • I have added necessary documentation (if appropriate)

Closing issues

Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 8 errors

⚠️ 2 warnings


skipped-files

Maximum number of lines exceeded (15000):

  • assets/build/blocks/rt-player/index.js

Note that the above file(s) were not analyzed due to their length.


Powered by rtCamp's GitHub Actions Library

assets/build/blocks/rt-player/frontend.asset.php Outdated Show resolved Hide resolved
assets/build/blocks/rt-player/frontend.asset.php Outdated Show resolved Hide resolved
assets/build/blocks/rt-player/frontend.asset.php Outdated Show resolved Hide resolved
assets/build/blocks/rt-player/frontend.asset.php Outdated Show resolved Hide resolved
assets/build/blocks/rt-player/index.asset.php Outdated Show resolved Hide resolved
assets/build/blocks/rt-player/index.asset.php Outdated Show resolved Hide resolved
assets/build/blocks/rt-player/index.asset.php Outdated Show resolved Hide resolved
assets/build/blocks/rt-player/index.asset.php Outdated Show resolved Hide resolved
inc/classes/class-assets.php Show resolved Hide resolved
inc/classes/class-blocks.php Show resolved Hide resolved
Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

⚠️ 1 warning


Powered by rtCamp's GitHub Actions Library

admin/rt-transcoder-rest-routes.php Show resolved Hide resolved
rtBot
rtBot previously requested changes Nov 19, 2024
Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 1 error


Powered by rtCamp's GitHub Actions Library

admin/rt-transcoder-actions.php Outdated Show resolved Hide resolved
Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 2 errors


Powered by rtCamp's GitHub Actions Library

admin/rt-transcoder-actions.php Outdated Show resolved Hide resolved
assets/src/blocks/rt-player/index.php Show resolved Hide resolved
Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 1 error

⚠️ 3 warnings


Powered by rtCamp's GitHub Actions Library

admin/rt-transcoder-actions.php Outdated Show resolved Hide resolved
admin/rt-transcoder-actions.php Show resolved Hide resolved
admin/rt-transcoder-actions.php Show resolved Hide resolved
admin/rt-transcoder-actions.php Show resolved Hide resolved
Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

⚠️ 2 warnings


Powered by rtCamp's GitHub Actions Library

admin/rt-transcoder-actions.php Show resolved Hide resolved
admin/rt-transcoder-actions.php Show resolved Hide resolved
@rtBot rtBot dismissed their stale review November 21, 2024 07:27

Dismissing review as all inline comments are obsolete by now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants