-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-179 : Implement nonce verification for Ajax calls #285
Conversation
Dismissing review as all inline comments are obsolete by now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Let's wait for @gagan0123's review.
Can you please check why "End-to-End Tests / Playwright Tests (pull_request) " is failing and fix that before the PR is merged? |
@gagan0123 Implemented specific nonce creation for every action. Still there are 2 ajax callbacks whose action can't be located in the codebase - https://github.com/rtCamp/transcoder/blob/master/admin/rt-transcoder-handler.php#L183-#L184 |
@SohamPatel46 You can remove that part of code, I've verified that it was used before, but later the functionality was removed without removing the WP AJAX endpoints.
|
@gagan0123 Removed unused AJAX actions and callback. Can you re-review it ? |
Thanks @SohamPatel46 for the PR 👍 @pavanpatil1 can you please test this branch to ensure the functionality is not impacted. Code looks good to me. |
Description