Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP deprecation errors for [email protected] #276

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Utsav-Ladani
Copy link
Contributor

Fix PHP deprecation errors for [email protected]

Fixes done in this PR

  • File: custom-functions.php
    • Change the null default value to 0 as the type is array|int.
  • File: rt-transcoder-handler.php
    • Change the apikey to string before passing to the trim() function because it gives an error if a parameter is not of type string.
    • Remove default arguments from the send_notification method because there should be no required arguments after default arguments in the method/function. Also added validation to convert it into an Array.
  • Also few other changes have been made to fix the phpcs errors.

Related Issues

Fix deprecation errors and phpcs errors

Closes: 275
Copy link

@vishalkakadiya vishalkakadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Utsav-Ladani Utsav-Ladani merged commit 686feee into develop Oct 18, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants