moveit_pyでロボットを動かすサンプルを追加します #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7fdbb47.
Kuwamai
requested changes
Dec 17, 2024
There was a problem hiding this comment.
@chama1176
PRありがとうございます。
いくつかコメントしたのでご確認お願いします。
また、READMEのパッケージ一覧部分にsciurus17_examples_pyの記述を追加お願いします。
https://github.com/rt-net/sciurus17_ros/tree/ros2?tab=readme-ov-file#packages
sciurus17_examples_py/sciurus17_examples_py/pick_and_place_left_arm.py
Outdated
Show resolved
Hide resolved
sciurus17_examples_py/sciurus17_examples_py/pick_and_place_right_arm_waist.py
Outdated
Show resolved
Hide resolved
sciurus17_examples_py/sciurus17_examples_py/pick_and_place_right_arm_waist.py
Outdated
Show resolved
Hide resolved
sciurus17_examples_py/sciurus17_examples_py/pick_and_place_left_arm.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Kuwamai <[email protected]>
Co-authored-by: Kuwamai <[email protected]>
Co-authored-by: Kuwamai <[email protected]>
Co-authored-by: Kuwamai <[email protected]>
…ht_arm_waist.py Co-authored-by: Kuwamai <[email protected]>
Co-authored-by: Kuwamai <[email protected]>
…t_arm.py Co-authored-by: Kuwamai <[email protected]>
…t_arm.py Co-authored-by: Kuwamai <[email protected]>
…ht_arm_waist.py Co-authored-by: Kuwamai <[email protected]>
…ht_arm_waist.py Co-authored-by: Kuwamai <[email protected]>
…t_arm.py Co-authored-by: Kuwamai <[email protected]>
|
@Kuwamai レビュー指摘事項修正しましたので、再確認お願いします 😺 |
Kuwamai
requested changes
Dec 23, 2024
There was a problem hiding this comment.
@chama1176 実機、シミュレータ両方で動作確認できました。パッケージ情報について少しコメントさせていただきましたのでご確認お願いします。
Co-authored-by: Kuwamai <[email protected]>
|
@chama1176 あとすみません！こちらのREADMEが更新できていればOKだと思います 🙇
|
|
@Kuwamai |
Kuwamai
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
moveit_pyでロボットを動かすサンプルを追加します
Does this close any currently open issues?
How has this been tested?
mock componentsを用いてCppサンプルと同様に動くことを確認
Any other comments?
Checklists