Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzy対応 #10

Open
wants to merge 14 commits into
base: ros2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/industrial_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ jobs:
env:
# テストがワークスペース内のパッケージに依存しているため、setup.bashを読み込む
# Ref: https://github.com/ros-industrial/industrial_ci/issues/585
- { ROS_DISTRO: humble, ROS_REPO: ros, BEFORE_RUN_TARGET_TEST_EMBED: "ici_with_unset_variables source /root/target_ws/install/setup.bash" }
# - { ROS_DISTRO: rolling, ROS_REPO: ros, BEFORE_RUN_TARGET_TEST_EMBED: "ici_with_unset_variables source /root/target_ws/install/setup.bash" }
- { ROS_DISTRO: jazzy, ROS_REPO: ros, BEFORE_RUN_TARGET_TEST_EMBED: "ici_with_unset_variables source /root/target_ws/install/setup.bash" }
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
7 changes: 4 additions & 3 deletions README.en.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@

ROS 2 package with URDF description macro for [CRANE-X7](https://rt-net.jp/products/crane-x7/).

## Supported ROS distributions
## Supported ROS 2 distributions

- [Foxy](https://github.com/rt-net/crane_x7_description/tree/foxy-devel)
- Humble
- [Humble](https://github.com/rt-net/crane_x7_description/tree/humble)
- [Jazzy](https://github.com/rt-net/crane_x7_description/tree/jazzy)

### ROS 1

Expand All @@ -22,7 +23,7 @@ ROS 2 package with URDF description macro for [CRANE-X7](https://rt-net.jp/produ
# Clone crane_x7_description and install dependencies
mkdir -p ~/ros2_ws/src
cd ~/ros2_ws/src
git clone -b ros2 https://github.com/rt-net/crane_x7_description
git clone -b $ROS_DISTRO https://github.com/rt-net/crane_x7_description.git
rosdep install -r -y -i --from-paths .

# Build the package
Expand Down
11 changes: 6 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,24 @@

[CRANE-X7](https://rt-net.jp/products/crane-x7/)のURDFファイルを含むROS 2パッケージです。

## サポートするROSディストリビューション
## サポートするROS 2ディストリビューション

- [Foxy](https://github.com/rt-net/crane_x7_description/tree/foxy-devel)
- Humble
- [Humble](https://github.com/rt-net/crane_x7_description/tree/humble)
- [Jazzy](https://github.com/rt-net/crane_x7_description/tree/jazzy)

### ROS 1

- [Melodic](https://github.com/rt-net/crane_x7_description/tree/master)
- [Noetic](https://github.com/rt-net/crane_x7_description/tree/master)
- [Melodic](https://github.com/rt-net/crane_x7_description/tree/v1.0.0)
- [Noetic](https://github.com/rt-net/crane_x7_description/tree/v1.0.0)

## インストール方法

```sh
# 本パッケージをクローンし、依存関係をインストールする
mkdir -p ~/ros2_ws/src
cd ~/ros2_ws/src
git clone -b ros2 https://github.com/rt-net/crane_x7_description
git clone -b $ROS_DISTRO https://github.com/rt-net/crane_x7_description.git
rosdep install -r -y -i --from-paths .

# パッケージをビルドする
Expand Down
3 changes: 2 additions & 1 deletion package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@
<license>NON-COMMERCIAL LICENSE AGREEMENT</license>

<author email="[email protected]">ShotaAk</author>
<author email="[email protected]">Nozomi Mizoguchi</author>

<buildtool_depend>ament_cmake</buildtool_depend>

<depend>ign_ros2_control</depend>
<depend>gz_ros2_control</depend>
<depend>joint_state_publisher_gui</depend>
<depend>launch</depend>
<depend>robot_state_publisher</depend>
Expand Down
4 changes: 2 additions & 2 deletions test/test_robot_description_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ def test_manipulator_links_file_path():


def test_use_gazebo():
# use_gazeboが変更され、xacroにign_ros2_controlがセットされることを期待
# use_gazeboが変更され、xacroにgz_ros2_controlがセットされることを期待
rdl = RobotDescriptionLoader()
rdl.use_gazebo = 'true'
rdl.gz_control_config_package = 'crane_x7_description'
rdl.gz_control_config_file_path = 'config/dummy_controllers.yaml'
assert 'ign_ros2_control/IgnitionSystem' in exec_load(rdl)
assert 'gz_ros2_control/GazeboSimSystem' in exec_load(rdl)


def test_use_d435():
Expand Down
2 changes: 1 addition & 1 deletion urdf/crane_x7.gazebo.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
">

<gazebo>
<plugin filename="libign_ros2_control-system.so" name="ign_ros2_control::IgnitionROS2ControlPlugin">
<plugin filename="libgz_ros2_control-system.so" name="gz_ros2_control::GazeboSimROS2ControlPlugin">
<parameters>$(find ${config_package})/${config_file_path}</parameters>
</plugin>
</gazebo>
Expand Down
19 changes: 10 additions & 9 deletions urdf/crane_x7.gazebo_ros2_control.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

<ros2_control name="${name}" type="system">
<hardware>
<plugin>ign_ros2_control/IgnitionSystem</plugin>
<plugin>gz_ros2_control/GazeboSimSystem</plugin>
</hardware>

<joint name="${name_joint_1}">
Expand Down Expand Up @@ -114,14 +114,15 @@
<state_interface name="velocity"/>
<state_interface name="effort"/>
</joint>
<joint name="${name_joint_gripper_finger_b}">
<param name="mimic">${name_joint_gripper_finger_a}</param>
<param name="multiplier">1</param>
<command_interface name="position"/>
<state_interface name="position"/>
<state_interface name="velocity"/>
<state_interface name="effort"/>
</joint>

<joint name="${name_joint_gripper_finger_b}">
<param name="mimic">${name_joint_gripper_finger_a}</param>
<param name="multiplier">1</param>
<command_interface name="position"/>
<state_interface name="position"/>
<state_interface name="velocity"/>
<state_interface name="effort"/>
</joint>

</ros2_control>
</xacro:macro>
Expand Down
Loading