Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in updateSelectizeInput() #3890

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Fix regression in updateSelectizeInput() #3890

merged 3 commits into from
Sep 8, 2023

Conversation

cpsievert
Copy link
Collaborator

Closes #3889

@cpsievert cpsievert marked this pull request as draft September 7, 2023 23:15
gadenbuie
gadenbuie approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally with an app that makes heavy use of updateSelectizeInput() and didn't notice any problems!

@cpsievert cpsievert marked this pull request as ready for review September 8, 2023 21:48
@cpsievert cpsievert merged commit eddc304 into main Sep 8, 2023
@cpsievert cpsievert deleted the selectize-bind branch September 8, 2023 21:48
cpsievert added a commit that referenced this pull request Oct 25, 2023
@cpsievert
Revert "Fix regression in updateSelectizeInput() (#3890)"
707c58c 
This reverts commit eddc304.
@cpsievert cpsievert mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in updateSelectizeInput() introduced by v0.15.2
2 participants
@cpsievert @gadenbuie