Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shiny's CSS to respect BS5's dark color mode #3882

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Aug 24, 2023

In support of rstudio/bslib#764. Easiest way to see/test this is to run bslib::bs_theme_preview(), then toggle a data-bs-theme="dark" attribute to the <body>/<html> tag.

@cpsievert cpsievert marked this pull request as ready for review August 28, 2023 15:24
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌃 🌉 🌙

@cpsievert cpsievert merged commit e87f942 into main Aug 28, 2023
11 checks passed
@cpsievert cpsievert deleted the css-dark-mode-bs5 branch August 28, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants