-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Shiny Event classes for custom events #3815
base: main
Are you sure you want to change the base?
Commits on Apr 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 01fd8fa - Browse repository at this point
Copy the full SHA 01fd8faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90c0523 - Browse repository at this point
Copy the full SHA 90c0523View commit details -
Remove
value
, addel
to ShinyEventInputChangedAlso mark `priority` as optional since it was optionally provided in practice
Configuration menu - View commit details
-
Copy full SHA for 8d12ae7 - Browse repository at this point
Copy the full SHA 8d12ae7View commit details -
Implement
EventCommon
andEventInputChanged
classesThese classes create the custom Shiny events and help us extend JQuery's event handlers for these event types.
Configuration menu - View commit details
-
Copy full SHA for 0e2d040 - Browse repository at this point
Copy the full SHA 0e2d040View commit details -
Use
EventInputChanged()
to emit file upload input eventWe now do this in place rather than as a separate function, i.e. we replace `triggerFileInputChanged()` with our improved abstraction.
Configuration menu - View commit details
-
Copy full SHA for e2d19b9 - Browse repository at this point
Copy the full SHA e2d19b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60f074d - Browse repository at this point
Copy the full SHA 60f074dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54fa857 - Browse repository at this point
Copy the full SHA 54fa857View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63427a7 - Browse repository at this point
Copy the full SHA 63427a7View commit details -
Implement one lower-level event class
EventBase
and useevent
rat……her than `evt` It turns out the props on EventCommon aren't used everywhere
Configuration menu - View commit details
-
Copy full SHA for 651b768 - Browse repository at this point
Copy the full SHA 651b768View commit details -
Configuration menu - View commit details
-
Copy full SHA for 922d16d - Browse repository at this point
Copy the full SHA 922d16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2740be1 - Browse repository at this point
Copy the full SHA 2740be1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5c6561 - Browse repository at this point
Copy the full SHA b5c6561View commit details -
Configuration menu - View commit details
-
Copy full SHA for a66ef6d - Browse repository at this point
Copy the full SHA a66ef6dView commit details -
Use
@babel/plugin-transform-typescript
It was already used by preset-typescript, but we need to use the plugin so that the transpilation happens at the right time, in particular because we are using `declare` within classes.
Configuration menu - View commit details
-
Copy full SHA for 08ced6b - Browse repository at this point
Copy the full SHA 08ced6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f50796 - Browse repository at this point
Copy the full SHA 4f50796View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce4961f - Browse repository at this point
Copy the full SHA ce4961fView commit details -
DRY properties and type definitions
* Use getters to expose data from `this.event` as if they were top-level * Refer to the interfaces directly rather than repeating type definitions
Configuration menu - View commit details
-
Copy full SHA for 0adeb4b - Browse repository at this point
Copy the full SHA 0adeb4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4648423 - Browse repository at this point
Copy the full SHA 4648423View commit details -
Configuration menu - View commit details
-
Copy full SHA for eddb0d9 - Browse repository at this point
Copy the full SHA eddb0d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 064da3a - Browse repository at this point
Copy the full SHA 064da3aView commit details
Commits on May 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 10c2398 - Browse repository at this point
Copy the full SHA 10c2398View commit details