Fix url bookmarking with possibility to modify excludes

[galachad]

This small bug fix the problem that exclude was created before onSave call. It's impacting the url bookmarking and this change made it consistent with the server bookmarking.

Minimal example:

library(shiny)

ui <- function(req) {
  fluidPage(
    sliderInput("obs", "Number of observations:",
                min = 0, max = 1000, value = 500
    ),
    textInput("text", "Label", "Data Summary"),
    plotOutput("distPlot"),
    bookmarkButton()
  )
}

# Server logic
server <- function(input, output) {
  output$distPlot <- renderPlot({
    hist(rnorm(input$obs))
  })

  onBookmark(function(state) {
    # Exclude from bookmarking
    state$exclude <- c("text")
  })
}

shinyApp(ui, server, enableBookmarking = "url")
# shinyApp(ui, server, enableBookmarking = "server")

[galachad]

Hi @wch, could you take a look on PR as it fixing the issue with evaluating exclusion on url bookmarking.

[CLAassistant]

All committers have signed the CLA.

[galachad]

Hi @cpsievert could you please look at this bug, it's a small fix to make the bookmarking functionality consistence for the URL and server.

[galachad]

Hi @jcheng5 could you, please look at this small bug fix. Thank you.

[cpsievert]

Hi @galachad, thanks for the nice PR and sorry for the long wait! Would you mind also updating the NEWS.md with an explanation of the bug fix?

[galachad]

@cpsievert Added a point to NEWS.md