Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make save_html() an S3 generic method #411

Merged
merged 8 commits into from
Oct 6, 2023
Merged

Make save_html() an S3 generic method #411

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d53c53
Make save_html() an S3 generic method
cpsievert Oct 5, 2023
de30ded
Make the generic...more generic
cpsievert Oct 6, 2023
47b03a1
`devtools::document()` (GitHub Actions)
cpsievert Oct 6, 2023
5ae307e
Bump version; update news
cpsievert Oct 6, 2023
5df5bbf
Add ... to method signature (and throw if they're non-empty)
cpsievert Oct 6, 2023
e450104
`devtools::document()` (GitHub Actions)
cpsievert Oct 6, 2023
f5caf7e
Clean Rd docs
cpsievert Oct 6, 2023
35cb742
Update NEWS.md
cpsievert Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ S3method(print,shiny.tag)
S3method(print,shiny.tag.env)
S3method(print,shiny.tag.list)
S3method(print,shiny.tag.query)
S3method(save_html,default)
S3method(str,shiny.tag.env)
export("htmlDependencies<-")
export(HTML)
Expand Down
5 changes: 5 additions & 0 deletions R/html_print.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ html_print <- function(html, background = "white", viewer = getOption("viewer",
#'
#' @export
save_html <- function(html, file, background = "white", libdir = "lib", lang = "en") {
UseMethod("save_html")
}

#' @export
save_html.default <- function(html, file, background = "white", libdir = "lib", lang = "en") {
cpsievert marked this conversation as resolved.
Show resolved Hide resolved
force(html)
force(background)
force(libdir)
Expand Down
Loading