Change calls to knitr:::%n% to %||% as %||% is a base function
#1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yihui
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Thanks! This operator is available only in R 4.4, so we have to define it for R versions below 4.4 like https://github.com/yihui/litedown/blob/376248c309f005175fa7f81e154f46b72c694a37/R/utils.R#L21
BTW, using ::: is not a design mistake in this particular case. I'm the maintainer of both bookdown and knitr, and I'm just stealing my own function from one package to another :)
yihui
changed the title
%n% to %||% as %||% is a base functionknitr:::%n% to %||% as %||% is a base function
yihui
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
knitr:::%n%and%||%are identical, but%||%is inbaseand%n%is an internal function of theknitrpackage.The R documentation states that using triple colon operator inside packages is typically a design mistake (https://stat.ethz.ch/R-manual/R-devel/library/base/html/ns-dblcolon.html) and in this case it can and should be avoided.