Drop support for rails versions < 7 in scaffold generator #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
approved these changes
Sep 2, 2024
JonRowe
added a commit
that referenced
this pull request
Sep 2, 2024
Drop support for rails versions < 7 in scaffold generator
JonRowe
added a commit
that referenced
this pull request
Sep 2, 2024
JonRowe
added a commit
that referenced
this pull request
Sep 2, 2024
|
Released in 7.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rspec-rails 7.0.0 release, my assumption is that it's safe/desired to drop support for any rails-conditional stuff earlier than 7.0?
This is a followup on #2777 which removes the conditional and just uses the style generated by rails 7.0 and higher.
Side note - opened this PR just b/c the prior one was mine and this change made sense to me from previous PR when I saw the 7.0.0 release version support. Would other PRs of this nature (cleaning up conditional support checks) be welcome?