Allow sqlite3 gem to float to version 2 #2783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to adjust this file, too. |
Rails main requires `sqlite3` version 2: rails/rails#51958
p8
force-pushed
the
support-sqlite3-2.0
branch
from
728faf4 to
ae89a74
Compare
|
Thanks @pirj ! |
pirj
reviewed
Aug 27, 2024
| @@ -16,7 +16,7 @@ if RUBY_VERSION.to_f < 3 | |||
| # sqlite3 1.7.x doesn't work on all platforms for Ruby 2.x | |||
| gem 'sqlite3', '~> 1.4', '< 1.7', platforms: [:ruby] | |||
| else | |||
| gem 'sqlite3', '~> 1.4', platforms: [:ruby] | |||
| gem 'sqlite3', '>= 1.4', platforms: [:ruby] | |||
There was a problem hiding this comment.
What if we required 2.0 only on Rails 8, which is main and did that in a case below on line 28?
The other file would need similar changes
There was a problem hiding this comment.
That other one is not merged yet, I’d keep this one open. Do you want to push this one forward with findings from #2784?
|
Closing in favour of #2784 thanks for starting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails main requires
sqlite3version 2:rails/rails#51958