Stop using webdrivers #2698
Merged
Stop using webdrivers #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn’t selenium-webdriver 4.10+ that is capable to use the selenium manager Ruby 3+ only? We’re fixing build issues at the moment, and this is the major one. If you have a clear idea how to download drivers for Ruby 2.6, 2.7 and 3+, that will help a lot. Please ignore Rails 7.1 and 7.0 builds, there’s at least some mailers failing spec. |
selenium-webdriver provides all that is needed now
|
Bare in mind this branch supports Rails 6 as well as 7, and this file is about making a new rails app work on CI, so this probably needs at least a version switch around the rails version, as we are modifying a default app's Gemfile... |
JonRowe
force-pushed
the
add-rails-71-directly
branch
from
d0e3089 to
1a8cc68
Compare
|
I didn't think this would work on 6.1 but it does, thus I'm going to merge it into #2692 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selenium-webdriver provides all that is needed now