Skip to content

Commit

Permalink
Clean up generator for generator specs
Browse files Browse the repository at this point in the history
Use singular name to match the generator name and use the generator name
in the spec description.

Also clean up an extra whitespace and empty line in the template.
  • Loading branch information
budu committed Mar 14, 2024
1 parent 260b3bf commit e063138
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions lib/generators/rspec/generator/generator_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Rspec
module Generators
# @private
class GeneratorGenerator < Base
class_option :generator_specs, type: :boolean, default: true, desc: "Generate generator specs"
class_option :generator_specs, type: :boolean, default: true, desc: 'Generate generator specs'

def generate_generator_spec
return unless options[:generator_specs]
Expand All @@ -17,7 +17,7 @@ def template_name
end

def filename
"#{table_name}_generator_spec.rb"
"#{file_name}_generator_spec.rb"
end
end
end
Expand Down
3 changes: 1 addition & 2 deletions lib/generators/rspec/generator/templates/generator_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
require 'rails_helper'

RSpec.describe "<%= class_name.pluralize %>", <%= type_metatag(:generator) %> do

RSpec.describe "<%= class_name %>Generator", <%= type_metatag(:generator) %> do
pending "add some scenarios (or delete) #{__FILE__}"
end

0 comments on commit e063138

Please sign in to comment.