Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config Flow support #30

Merged

Conversation

robert-alfaro
Copy link
Contributor

@robert-alfaro robert-alfaro commented Aug 22, 2024

Converted configuration to use Config Flow instead of YAML. Also moved away from needing to specify URL in favor of providing the share_id from the URL (the trailing portion).

@robert-alfaro robert-alfaro force-pushed the feature/config-flow-support branch from 38aa60d to 7f3a264 Compare August 22, 2024 22:13
@rsnodgrass
Copy link
Owner

Great changes!

However, can we make this a non-breaking change by continuing to support CONF_URL (if defined) instead of ONLY allowing share id? Then everyone who uses this doesn't have to manually go change when this is updated (especially if they have auto-updates setup on integrations and may not see the changelog).

We can leave the documentation showing only share id moving forward, but at least things won't break for people.

@rsnodgrass
Copy link
Owner

Thanks for cleaning up a few other things too!

@robert-alfaro
Copy link
Contributor Author

I'm for backwards compatibility but unless I'm mistaken by moving away from yaml to config flow...that is a breaking change. I could be wrong but I'm thinking of several cases where I've had to manually remove the configuration.yaml text and re-setup via ui. It is because of this fact I decided to move to share id, and those users already have the share id, just need to copy paste into ui flow anew.

Thoughts?

@rsnodgrass
Copy link
Owner

rsnodgrass commented Aug 27, 2024 via email

@robert-alfaro
Copy link
Contributor Author

I guess I've not been fortunate to have experienced a well behaved migrating integration. Regardless sounds good... I'll look into it.

@robert-alfaro robert-alfaro force-pushed the feature/config-flow-support branch from a47cfa4 to 0ba49b7 Compare August 27, 2024 22:25
@rsnodgrass rsnodgrass merged commit c891612 into rsnodgrass:master Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants