Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JMH tests #2898

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix JMH tests #2898

merged 1 commit into from
Dec 20, 2024

Conversation

nagarev
Copy link
Contributor

@nagarev nagarev commented Dec 19, 2024

Description

After adding reverted transaction handling to the eth_estimateGas method, the previous tx didn't worked as it was being reverted and the jmh test was receiving an exception instead of a numeric value.

Motivation and Context

It fixes an issue on jmh tests

How Has This Been Tested?

By running the jmh test suite

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

N/A

Copy link

github-actions bot commented Dec 19, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vovchyk Vovchyk merged commit fb1957f into master Dec 20, 2024
13 checks passed
@Vovchyk Vovchyk deleted the fix-jmh branch December 20, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants