Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the use of serializeCompactV2 and deserializeCompactV2 #2859

Open
wants to merge 1 commit into
base: 32-byte-chainwork-support-integration
Choose a base branch
from
Open

Add the use of serializeCompactV2 and deserializeCompactV2 #2859

wants to merge 1 commit into from
+468 −5

Conversation

nathanieliov
Copy link
Contributor

Description

  • Add the use of serializeCompactV2
  • Add the use of deserializeCompactV2

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

@nathanieliov nathanieliov requested a review from a team November 22, 2024 04:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@nathanieliov nathanieliov marked this pull request as ready for review November 22, 2024 13:15
@nathanieliov nathanieliov changed the title - Add the use of serializeCompactV2 - Add the use of serializeCompactV2 and deserializeCompactV2 Nov 22, 2024
@nathanieliov nathanieliov changed the title - Add the use of serializeCompactV2 and deserializeCompactV2 Add the use of serializeCompactV2 and deserializeCompactV2 Nov 22, 2024
jeremy-then
jeremy-then approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nathanieliov nathanieliov force-pushed the 32-byte-chainwork-support-integration branch from 72a2869 to 11d1a8b Compare November 26, 2024 18:09
@nathanieliov
- Add the use of serializeCompactV2
d9cab35 
- Add the use of deserializeCompactV2
@nathanieliov nathanieliov force-pushed the use-serializeAndDeserializeCompactV2-in-RepositoryBtcBlockStoreWithCache branch from 0d88d29 to d9cab35 Compare November 26, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremy-then jeremy-then jeremy-then approved these changes

@apancorb apancorb apancorb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanieliov @apancorb @jeremy-then