Include SVP transactions as possible transaction types to be used by the Bridge

[marcos-iov]

Description

• Create a FederationContext class, to hold information about active and retiring federations
• Refactor PegUtils methods to receive a FederationContext object instead of each element separately
• Update getTransactionType method to detect SVP related transactions
• Update PegTxType enum to add SVP types
• Update registerBtcTransaction to detect and process SVP related transactions

Motivation and Context

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

• Other information:

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[apancorb]

Looking good to me

[julia-zack]

nit:

Federation retiringFederation = federationContext.getRetiringFederation();
assertTrue(retiringFederation.isPresent());
assertEquals(retiringFederation, retiringFederation.get());

[julia-zack]

same here:

Script lastRetiredFederationP2SHScript = federationContext.getLastRetiredFederationP2SHScript();
assertTrue(lastRetiredFederationP2SHScript.isPresent());
assertEquals(lastRetiredFederationP2SHScript, lastRetiredFederationP2SHScript.get());

[nathanieliov]

Suggested change

	public FederationContext(Federation activeFederation) {
	this.activeFederation = activeFederation;
	}
	private FederationContext(Federation activeFederation) {
	this.activeFederation = activeFederation;
	}
	public static FederationContext of(Federation activeFederation) {
	return new FederationContext(activeFederation);
	}

[nathanieliov]

Suggested change

	Federation getActiveFederation();
	/**
	* Returns the currently active federation.
	* See getActiveFederationReference() for details.
	* @return the active federation.
	*/
	Federation getActiveFederation();
	Federation getActiveFederation();

[nathanieliov]

We need to update this message. Maybe make sense to just say "This is not a bridge transaction".

[nathanieliov]

Suggested change

	retiringFederation.ifPresent(
	federation -> standardP2shScripts.add(getFederationStandardP2SHScript(federation))
	);
	retiringFederation.map(PegUtilsLegacy::getFederationStandardP2SHScript).ifPresent(standardP2shScripts::add);