Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Bridge related tests #2706

Merged
merged 17 commits into from
Sep 12, 2024
Merged

Refactor Bridge related tests #2706

merged 17 commits into from
Sep 12, 2024

Conversation

marcos-iov
Copy link
Contributor

  • Remove unthrown exceptions from the methods declaration
  • Rename variables
  • Move utils methods to it's own class

@marcos-iov marcos-iov requested a review from a team as a code owner September 3, 2024 18:41
jeremy-then
jeremy-then previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

apancorb
apancorb previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@apancorb apancorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! LGTM

@marcos-iov marcos-iov dismissed stale reviews from apancorb and jeremy-then via bc13adb September 6, 2024 13:42
@marcos-iov
Remove unthrown exceptions from the method signatures
fba3cf3
@marcos-iov
Rename variables in tests
dde9970
@marcos-iov
Update FederationTestUtils to create an ERP federation similar to the…
5bb11d5 
… one in mainnet
@marcos-iov
Move flatKeysAsByteArray method to BitcoinTestUtils
8a3d673
@marcos-iov
Refactor BridgeEventLoggerImplTest
b5a255f
@marcos-iov
Add a static builder method to P2shErpFederationBuilder
bba81f7
@marcos-iov
Add a static builder method to PendingFederationBuilder
e24caf0
@marcos-iov
Add a static builder method to StandardMultiSigFederationBuilder
06e5046
@marcos-iov
Rename variables in tests
8548a31
@marcos-iov
Use all active forks in a test
f8816af
@marcos-iov
Rename values of FederationType enum in PowpegMigrationTest to be upp…
eaed340 
…er case
@marcos-iov
Improve activations object used in tests
3878e19
@marcos-iov
Cleanup BridgeSupportIT class
18a0abd
@marcos-iov
Cleanup BridgeSupportTest class
fe972e5
@marcos-iov
Cleanup PegUtilsGetTransactionTypeTest class
6ab44a6
@marcos-iov
Cleanup BridgeSupportProcessFundsMigrationTest class
5c7b1a1
@marcos-iov
Cleanup remaining test classes
4fbdf69
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@josedahlquist josedahlquist merged commit 128bcdb into master Sep 12, 2024
9 of 10 checks passed
@marcos-iov marcos-iov deleted the refactor-tests branch September 17, 2024 19:50
@aeidelman aeidelman added this to the Arrowhead 6.4.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julia-zack julia-zack julia-zack approved these changes

@josedahlquist josedahlquist josedahlquist approved these changes

@jeremy-then jeremy-then jeremy-then left review comments

@apancorb apancorb apancorb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Arrowhead 6.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@marcos-iov @josedahlquist @apancorb @julia-zack @jeremy-then @aeidelman