PP-136/smart wallet transfer #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e value on directExecute
antomor
approved these changes
May 26, 2022
| "testToken": "0x5D0aBdE7Ed6B7e122eD55EAe514E617d6c08f407" | ||
| } | ||
| } | ||
| {"31":{"penalizer":"0x91FdF681D6e2294bC2bd4D6B8F2685AA95Ee2Aa2","relayHub":"0x66Fa9FEAfB8Db66Fe2160ca7aEAc7FC24e254387","smartWallet":"0xEdB6D515C2DB4F9C3C87D7f6Cefb260B3DEe8014","smartWalletFactory":"0xeaB5b9fA91aeFFaA9c33F9b33d12AB7088fa7f6f","smartWalletDeployVerifier":"0x5C6e96a84271AC19974C3e99d6c4bE4318BfE483","smartWalletRelayVerifier":"0x56ccdB6D312307Db7A4847c3Ea8Ce2449e9B79e9","customSmartWallet":"0x25b03F90DD4D20Ba500b1950e3E3044ebC49E5fD","customSmartWalletFactory":"0x425A3d21eB298480b45d5f6D9b20cAcc27660E01","customSmartWalletDeployVerifier":"0x24445B6454cA52f6d8B2716952dA9D1Fc30B4344","customSmartWalletRelayVerifier":"0x9c29fEE0317178c69c411aeD358Ffb17E4EbFe29","sampleRecipient":"0x22167CE0c7646C49049a6Ae9F877a14310d24B4E","testToken":"0xF5859303f76596dD558B438b18d0Ce0e1660F3ea"},"33":{"penalizer":"0x7562af45f4D0F1C3a3e09ba62ABd61dec68aB925","relayHub":"0x4Bc162B5ed6967E8c7F38d46a6d56ec122ffca43","smartWallet":"0xD1003d10f6E426d1B1c82CEbe5E1cb4128589deB","smartWalletFactory":"0xfb633E977B84ffF04eEc12C3c9785caD3846d9fD","smartWalletDeployVerifier":"0xB4c021f13840880b04C985dc5ef07bb8A484dF59","smartWalletRelayVerifier":"0x829Bfae4c492b737BE00B635076daB2BDFc46c55","customSmartWallet":"0x267D1cABA390C21df371aD02fDeF2dbc966a015C","customSmartWalletFactory":"0x729f67cB6478C30F36b772bc5A70aB568e9DC21e","customSmartWalletDeployVerifier":"0x1bF847Ff9800F3E6C03Ea4780e4F4249982c851C","customSmartWalletRelayVerifier":"0x0ae32078Fd1A3563cdC43672D1D78cDeB9fC177b","sampleRecipient":"0xFAF0d39D89D41A6A1E6D939cD55126a46a1E75B1","testToken":"0x86c406E582A360A1BfE363e28988Ae96780bEEe3"}} |
There was a problem hiding this comment.
It doesn't hurt, but I don't think we need this change, do we?
There was a problem hiding this comment.
thought this file was meant to be generated in deployment?
|
@franciscotobar Thank you for this PR. Before merging it, we may need to change the dapp to reflect these changes. |
|
We decide to implement a new SmartWallet instead of changing the existing one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removed the process where native cryptocurrency balance is transfer back to the owner EOA
Why
It would be more consistent (simpler, in UX terms) to leave the native cryptocurrency balance in the SmartWallet instead of transferring it to the owner EOA after each execution.
Refs