-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scorecard #326
Scorecard #326
Conversation
bcodesido
commented
Oct 17, 2024
•
edited
Loading
edited
- Add scorecard workflow
- Add codeql workflow
- Add dependency-check workflow
- Add dependabot configuration
- Add License
- Fix workflow permissions
- Bump action versions
- Add Scorecard badge on README file
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Manifest Files.github/workflows/build-push-docker.yml
.github/workflows/build_and_test.yml
.github/workflows/codeql.yml.github/workflows/dependency-review.yml.github/workflows/reproducible.yml
.github/workflows/rit.yml.github/workflows/scorecard.yml |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Add scorecard workflow Add codeql workflow Add dependency-check workflow
Quality Gate passedIssues Measures |
@@ -20,7 +20,7 @@ RUN gpg --keyserver https://secchannel.rsk.co/SUPPORT.asc --recv-keys 1DC9157991 | |||
./gradlew --no-daemon clean build -x test && \ | |||
cp "build/libs/federate-node-$RSK_VERSION-all.jar" rsk.jar | |||
|
|||
FROM eclipse-temurin:17-jre | |||
FROM eclipse-temurin:17-jre@sha256:f1515395c0695910a3ca665e973cc11013d1f50d265e61cb8c9156e999d914b4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big deal but, should this be so indented?
- package-ecosystem: docker | ||
directory: / | ||
schedule: | ||
interval: daily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we leave a new line at the end of all files? Some files in this pr preview are complaining with the ⛔ symbol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments. Overall, LGTM.