Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to 32 bytes chain work #122

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Add support to 32 bytes chain work #122

wants to merge 21 commits into from

Conversation

nathanieliov
Copy link
Contributor

These changes provide a long-term fix for the 12-byte bug that we had at btc block 849,138.

List of the changes done.

  • Added deserializeCompactV2 method to deserialize block with 32-byte chain work.
  • Added serializeCompactV2 method to serialize block with 32-byte chainwork
  • Deprecated CheckpointManager.readBinary method
  • Added read binary checkpoints unit tests
  • Added the use of deserializeCompactV2 to support 32 bytes chain work when reading textual checkpoints format

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

nathanieliov and others added 21 commits November 7, 2024 20:07
@nathanieliov
Add serializeCompactV2 method to serialize 32 byte chainwork
648265a
@nathanieliov
Add tests for serializeCompactV2
d2a3d64
@nathanieliov
- Improve comments
5a68543 
- Reorganize statics
- Remove unrelated tests
@nathanieliov
- Improve comments to understand key class variables meaning
7ff0568 
- Rename serializeCompact to serializeCompactLegacy to avoid confusion
- Add deprecate tag to serializeCompactLegacy
- Remove unnecessary check of chainWorkBytes size
@nathanieliov
- Renamed V1 format class variables
503087c 
- Refactored serializeCompactLegacy and serializeCompactV2 to get rid of duplicate logic
- Refactored StoredBlockTest to make it easier to follow
@nathanieliov
Add deserializeCompactV2 method to deserialize 32 byte chain work
c8928bb
@nathanieliov
Add tests for deserializeCompactV2
a808102
@nathanieliov
- Renamed deserializeCompact to deserializeCompactLegacy
4e464c3 
- Deprecated deserializeCompactLegacy
@nathanieliov
- Refactored deserializeCompactLegacy and deserializeCompactV2 to get…
2636eb3 
… rid of duplicate logic
@nathanieliov
- Update CheckpointManager description comment
5c87a90 
- Deprecate CheckpointManager.readBinary  method
@nathanieliov
- Update readBinary method to throw an exception when processed malfo…
7a772f0 
…rmed checkpoints file

- Add read binary checkpoints unit tests
- Add testnet and mainnet binary sample file for unit tests
@nathanieliov
Fix issues after rebased
457b586
@marcos-iov
Merge pull request #118 from rsksmart/add-serializeCompactV2-method
cb17119 
Add serializeCompactV2 method to serialize block with 32-byte chainwork
@marcos-iov
Merge pull request #119 from rsksmart/add-deserializeCompactV2-method
a7d45ba 
Add deserializeCompactV2 method to deserialize block with 32-byte chain work
@nathanieliov
- Updated wrong reference.
cd8dad9 
- Fix conditional to use context variable making more clear the purpose of it
@nathanieliov
- Renamed deserializeCompact to deserializeCompactLegacy
4e12464 
- Deprecated deserializeCompactLegacy
@nathanieliov
Add support to 32 bytes chain work to textual checkpoints format
d21a3f0
@nathanieliov
Add tests for textual format reading
f0f8553
@marcos-iov
Merge pull request #120 from rsksmart/deprecate-readBinary-method
5cce037 
Deprecate CheckpointManager.readBinary  method
@nathanieliov
Add deprecate annotation to deserializeCompactLegacy
2de4cac
@marcos-iov
Merge pull request #121 from rsksmart/use-deserializeCompactV2-method
4482068 
Add support to 32 bytes chain work to textual checkpoints format
@nathanieliov nathanieliov requested a review from a team November 20, 2024 15:18
@nathanieliov nathanieliov marked this pull request as ready for review November 20, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanieliov @marcos-iov