Trying to fix the CI #510
Merged
Trying to fix the CI #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
reviewed
Dec 5, 2024
| @@ -12,7 +12,7 @@ max-line-length=120 | |||
|
|
|||
| [tox] | |||
| # sync with /.github/workflows/fedora-tox.yml | |||
| envlist = py{36,37,311,312,313} | |||
There was a problem hiding this comment.
I'd personally keep 3.6/3.9/3.12 as EPELs use those, see #509
praiskup
reviewed
Dec 5, 2024
.packit.yml
Outdated
| - <<: *copr | ||
| trigger: commit | ||
| metadata: | ||
| - epel-9-x86_64 | ||
| owner: "@rpm-software-management" |
There was a problem hiding this comment.
Seems like you are moving the pull-request builds into the production project, not sure?
There was a problem hiding this comment.
Oh, you are right, that's wrong. But we need to specify the same targets for the trigger: commit though.
There was a problem hiding this comment.
Because this was submitted for the last commit in the main branch https://github.com/rpm-software-management/tito/runs/33928767738 and shouldn't have been.
praiskup
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.