Fix traceback related to undefined variable #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts part of 68d8b21
praiskup
commented
Jan 16, 2024
| error_out("Unable to locate branch configuration: %s\n" | ||
| "Please run 'tito init' or use '--without-init' parameter" | ||
| % filename) | ||
|
|
||
| config = RawConfigParser() | ||
| config.read(filename) |
There was a problem hiding this comment.
The filename here was undefined.
|
Fixes #486 |
praiskup
commented
Jan 16, 2024
| filename = os.path.join(rel_eng_dir, TITO_PROPS) | ||
| if not os.path.exists(filename): | ||
| error_out("Unable to locate branch configuration: %s\n" | ||
| "Please run 'tito init' or use '--without-init' parameter" |
There was a problem hiding this comment.
This comment doesn't feel right :-) but it fixes the bug... so perhaps we don't need to check for the file existence?
|
I'd propose a different fix. Maybe I am missing something though. Do you think this will work? diff --git a/src/tito/cli.py b/src/tito/cli.py
index 762f49b..3d3a520 100644
--- a/src/tito/cli.py
+++ b/src/tito/cli.py
@@ -98,7 +98,7 @@ def _read_config(self):
# building, we may also load that and potentially override some global
# settings.
config = RawConfigParser()
- config.read(filename)
+ config.read(self.tito_props_path)
self._check_legacy_globalconfig(config)
return config |
FrostyX
added a commit
to FrostyX/tito
that referenced
this pull request
Jan 28, 2024
Fixup after 68d8b21 Obsoletes PR rpm-software-management#487
|
I think we can close this in favor of PR #489 |
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts part of 68d8b21