Building in non-initialized project without explicit parameter #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I renamed the |
|
Do we have a project to test this? Otherwise looks good to me. |
|
I tested by |
praiskup
reviewed
Jan 10, 2024
src/tito/cli.py
Outdated
| "Please run 'tito init'" % loader.tito_props_path) | ||
|
|
||
| if not self.options.ignore_missing_config: | ||
| warn_out("Tito project wasn't initialized," |
There was a problem hiding this comment.
nit: missing space separator after comma
|
This is awesome, thank you. |
The behavior changed. We now build non-initialized projects without any additional parameter. The `--without-init` could be confusing because it could be understood as ignoring `.tito` directory even if it is there. Which is not true, if `.tito` directory exists, the parameter does nothing. It is only used to silence warnings.
FrostyX
force-pushed
the
without-init-2
branch
from
539cdb9 to
0a59981
Compare
|
Nit fixed, thank you for the review :-) |
FrostyX
merged commit 18b1bad
into
rpm-software-management:master
6 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #472
Now, it is possible to build packages without using any parameters.
To silence the warnings, it is possible to use the
--without-initparameterIf the
.titodirectory exists, the--without-initparameter does nothing. So when integrating into Copr, the--wihout-initparameter can be used every time for every project. But maybe we should rename it to--ignore-missing-init,--ignore-missing-config,--ignore-init-warnings, or something like that?One more thing that I realized is that we can only build in non-initialized projects when using
--test. Without it, we getWe will need that for Copr, right @praiskup?