Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding fs in tokio features to support fs #184

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

godmodegalactus
Copy link
Contributor

Currently with newer versions of tokio does not compile because it requires feauture flag fs enabled in Cargo.toml

@fanatid
Copy link
Collaborator

fanatid commented Sep 21, 2023

I tried to update tokio to 1.32.0 locally and looks like everything is fine. Can you please show an example or paste the steps to reproduce?

@godmodegalactus
Copy link
Contributor Author

image

@godmodegalactus
Copy link
Contributor Author

[[package]]
name = "tokio"
version = "1.28.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "94d7b1cfd2aa4011f2de74c2c4c63665e27a71006b0a192dcd2710272e73dfa2"
dependencies = [
 "autocfg",
 "bytes",
 "libc",
 "mio",
 "num_cpus",
 "pin-project-lite",
 "signal-hook-registry",
 "socket2",
 "tokio-macros",
 "windows-sys 0.48.0",
]

[[package]]
name = "tokio-io-timeout"
version = "1.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "30b74022ada614a1b4834de765f9bb43877f910cc8ce4be40e89042c9223a8bf"
dependencies = [
 "pin-project-lite",
 "tokio",
]

[[package]]
name = "tokio-macros"
version = "2.1.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "630bdcf245f78637c13ec01ffae6187cca34625e8c63150d424b59e55af2675e"
dependencies = [
 "proc-macro2",
 "quote",
 "syn 2.0.29",
]

[[package]]
name = "tokio-rustls"
version = "0.24.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "c28327cf380ac148141087fbfb9de9d7bd4e84ab5d2c28fbc911d753de8a7081"
dependencies = [
 "rustls",
 "tokio",
]

[[package]]
name = "tokio-stream"
version = "0.1.14"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "397c988d37662c7dda6d2208364a706264bf3d6138b11d436cbac0ad38832842"
dependencies = [
 "futures-core",
 "pin-project-lite",
 "tokio",
]

[[package]]
name = "tokio-util"
version = "0.7.8"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "806fe8c2c87eccc8b3267cbae29ed3ab2d0bd37fca70ab622e46aaa9375ddb7d"
dependencies = [
 "bytes",
 "futures-core",
 "futures-sink",
 "pin-project-lite",
 "tokio",
 "tracing",
]

@godmodegalactus
Copy link
Contributor Author

I am just building the gyser plugin, apparently there is already tokio::fs included in yellowstone-grpc-kafka library. In anycase this should not happen.

@fanatid
Copy link
Collaborator

fanatid commented Sep 21, 2023

@godmodegalactus can you please merge this pr? godmodegalactus#1

@godmodegalactus
Copy link
Contributor Author

I cannot merge it my self, i have not rights I guess. But you can.

@fanatid
Copy link
Collaborator

fanatid commented Sep 21, 2023

godmodegalactus#1 in your fork to branch in this PR 🙂 only add line to CHANGELOG.md amount this change

@godmodegalactus
Copy link
Contributor Author

godmodegalactus#1 in your fork to branch in this PR 🙂 only add line to CHANGELOG.md amount this change

done

@fanatid fanatid merged commit 8a2c898 into rpcpool:master Sep 21, 2023
2 checks passed
@fanatid
Copy link
Collaborator

fanatid commented Sep 21, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants