Add geyser plugin runner #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanatid
reviewed
Feb 11, 2024
There was a problem hiding this comment.
Can we use workspaces here? https://doc.rust-lang.org/cargo/reference/workspaces.html
would be good to have rust-toolchain.toml so rust version would be fixed https://rust-lang.github.io/rustup/overrides.html
| } | ||
|
|
||
| impl DataFrame { | ||
| pub fn from_bytes(data: Vec<u8>) -> Result<DataFrame, Box<dyn Error>> { |
There was a problem hiding this comment.
anyhow + thiserror usually is idiomatic error handing in rust
| pub fn from_bytes(data: Vec<u8>) -> Result<DataFrame, Box<dyn Error>> { | ||
| let decoded_data: serde_cbor::Value = serde_cbor::from_slice(&data).unwrap(); | ||
| let data_frame = DataFrame::from_cbor(decoded_data)?; | ||
| return Ok(data_frame); |
There was a problem hiding this comment.
Suggested change
| return Ok(data_frame); | |
| Ok(data_frame) |
I guess there more things like this, would be good to have cargo tree / fmt / clippy in CI
linuskendall
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the rust code that can be used to read old-faithful CAR files and send their contents to a Solana geyser plugin.
This PR provides the rust libraries to read CAR files, and a CLI to dum a CAR file to a geyser plugin.