Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update template for django 3 #17

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

21adrian1996
Copy link

No description provided.

@rparent
Copy link
Owner

rparent commented Mar 8, 2021

Thanks for the PR, looks good!

Seems to me that it would break support of django < 1.10 though. But I guess it is not worth maintaining the package for those old versions. Just need to update the README.

Making plugin translatable is also a good idea!

@codecov-io
Copy link

codecov-io commented Mar 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@a0c7933). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   86.46%           
=========================================
  Files             ?       16           
  Lines             ?      399           
  Branches          ?       25           
=========================================
  Hits              ?      345           
  Misses            ?       41           
  Partials          ?       13           
Impacted Files Coverage Δ
lock_tokens/admin.py 76.47% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c7933...f890b68. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@a0c7933). Click here to learn what that means.
The diff coverage is 66.66%.

❗ Current head f890b68 differs from pull request most recent head 1268d0e. Consider uploading reports for the commit 1268d0e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   86.46%           
=========================================
  Files             ?       16           
  Lines             ?      399           
  Branches          ?       25           
=========================================
  Hits              ?      345           
  Misses            ?       41           
  Partials          ?       13           
Impacted Files Coverage Δ
lock_tokens/admin.py 76.47% <66.66%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nschlemm
Copy link

nschlemm commented Jun 4, 2023

@rparent can you give us an update on integrating this please? thx!

@lebouquetin
Copy link

Hi @nschlemm @21adrian1996 @rparent

For an internal project, I did fork the repo - see https://github.com/algoo/django-lock-tokens

I also merge the current PR + upgraded dependencies to Python 3.12 / Django 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants