Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve randomness #5268

Closed
wants to merge 2 commits into from
Closed

Conversation

paragonie-scott
Copy link

Closes #5266

@alecpl
Copy link
Member

alecpl commented May 25, 2016

I don't like it. There's no exceptions handling where random_* functions are used. We should just use rcube_utils::random_bytes(). From the other side, we'll not hit lack-of-entropy issue if we use real random functions everywhere?

@paragonie-scott
Copy link
Author

In that case: You might also want to consider creating a rcube_utils::random_int() that handles exceptions from \random_int() and replace all mt_rand()/rand() invocations with rcube_utils::random_int().

@alecpl alecpl closed this Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants