Password plugin, cPanel driver #5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for cPanel remote access hash (choice between hash auth and plain password auth).
Add support for cPanel hash auth, using a Remote Access Key (choice between hash auth and plain password auth).
Add support for hash auth (cPanel Remote Access Key) and call the $xmlapi->listaccts() method to retrieve the cPanel account user that owns the domain (required for cPanel reseller accounts).
|
Could you keep our code style and indentation, please? |
Changed code style and indentation.
|
Sure. I've fixed it in commit 8042955 |
| } | ||
| // Pass auth | ||
| else if (!empty($rcmail->config->get('password_cpanel_password'))) { | ||
| $this->xmlapi->hash_auth( $this->cuser, $rcmail->config->get('password_cpanel_password')); |
There was a problem hiding this comment.
Here password_hash() should be used. Also, I'd like to see config->get() use once per option.
There was a problem hiding this comment.
I've modified the code to call config->get() only once. Commit is here:
7ed0d33
The hash key here is a unique remote access key that's generated and stored in the WHM user's account. For example, for the root user, it would be stored in /root/.accesshash. I don't think it can be generated outside of the WHM interface.
https://documentation.cpanel.net/display/ALD/Remote+Access+Key
Call $rcmail->config->get() only once per option by assigning variable inside the IF statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for hash auth (cPanel Remote Access Key) in the Password plugin's cPanel driver and call the $xmlapi->listaccts() method to retrieve the cPanel account user that owns the domain (required for cPanel reseller accounts).