warning "idn_to_utf8(): INTL_IDNA_VARIANT_2003 is deprecated" with PHP 7.2

[hannob]

When running latest roundcube 1.3.3 with PHP 7.2 I get warnings in my log:
PHP Deprecated: idn_to_utf8(): INTL_IDNA_VARIANT_2003 is deprecated in [path]/htdocs/program/lib/Roundcube/rcube_utils.php on line 880

I don't find "INTL_IDNA_VARIANT_2003" anywhere in the code, so I guess it's somehow set implicitly.

[alecpl]

That's a PHP bug. They made that variant deprecated, but did not changed the default value of 3rd argument of idn_to_utf8(). Not smart. I suppose we'd need to set it explicitely.

http://php.net/manual/en/function.idn-to-utf8.php

[hannob]

oh yeah, that's truly a PHP bug. I'll report it to upstream, let's see what happens, if they decide to fix it quickly and it'll be no more issue in 7.2.1 then maybe no fix is needed in roundcube.

[hannob]

Bug report at PHP: https://bugs.php.net/bug.php?id=75609

[hannob]

As weird as it sounds, it seems PHP did this intentionally. See discussion in linked bug and here:
https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003

While I strongly disagree with PHP here and think this is incredibly illogical, I have doubts they'll change their opinion given that PHP 7.2 is already out. Probably the best course of action is to explicitly set the variant to INTL_IDNA_VARIANT_UTS46 and add a comment that this change can be reverted in a few years when PHP 7.4 is the new norm and idn_to_utf8() can be used in its default mode without warnings again.

[alecpl]

Fixed.