Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update class-amp-http.php #1834

Closed
wants to merge 5 commits into from
Closed

Conversation

s-a-s-k-i-a
Copy link

In PHP 7.2/7.3 calling idn_to_* functions with default arguments throws a warning. Thus we must set the variant and options explicitely.
lines 208 - 212 fixed

In PHP 7.2/7.3 calling idn_to_* functions with default arguments throws a warning. Thus we must set the variant explicitely
lines 208 - 212 fixed
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no Has not signed the Google CLA label Jan 20, 2019
@s-a-s-k-i-a
Copy link
Author

s-a-s-k-i-a commented Jan 20, 2019 via email

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@s-a-s-k-i-a
Copy link
Author

s-a-s-k-i-a commented Jan 20, 2019 via email

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Jan 20, 2019
@westonruter
Copy link
Member

See #1439 and #1440 for where the existing code came from.

See also Automattic/jetpack#10945 (comment) and Automattic/jetpack#10945 (comment). This would fix the issue reported there?

line 212: warning - Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)
@swissspidy
Copy link
Collaborator

New PR: #1987

@swissspidy swissspidy closed this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants