-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update class-amp-http.php #1834
Conversation
In PHP 7.2/7.3 calling idn_to_* functions with default arguments throws a warning. Thus we must set the variant explicitely lines 208 - 212 fixed
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it!
… Am 20.01.2019 um 07:38 schrieb googlebot ***@***.***>:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ <https://cla.developers.google.com/> to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data <https://cla.developers.google.com/clas> and verify that your email is set on your git commits <https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot <http://go/cla#troubleshoot> (Public version <https://opensource.google.com/docs/cla/#troubleshoot>).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data <https://cla.developers.google.com/clas> and verify that your email is set on your git commits <https://help.github.com/articles/setting-your-email-in-git/>.
The email used to register you as an authorized contributor must also be attached to your GitHub account <https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1834 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADXGRW8k5CSAMx8BbUQMkeblfnc1IFl5ks5vFA7OgaJpZM4aJfw4>.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Check again..
… Am 20.01.2019 um 07:41 schrieb googlebot ***@***.***>:
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here <https://cla.developers.google.com/> to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1834 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADXGRWHdB19XRbNYgJTceSySmAaTPFVKks5vFA-AgaJpZM4aJfw4>.
|
CLAs look good, thanks! |
See #1439 and #1440 for where the existing code came from. See also Automattic/jetpack#10945 (comment) and Automattic/jetpack#10945 (comment). This would fix the issue reported there? |
line 212: warning - Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)
Co-Authored-By: s-a-s-k-i-a <[email protected]>
This is an alternative, simpler approach to #1834.
New PR: #1987 |
In PHP 7.2/7.3 calling idn_to_* functions with default arguments throws a warning. Thus we must set the variant and options explicitely.
lines 208 - 212 fixed