Possible defect in source code (CWE-570)

[AppChecker]

Hello!

We've checked your code with AppChecker static analyzer and found possible bug:

roundcubemail/plugins/managesieve/lib/Roundcube/rcube_sieve_script.php

Line 1263 in ad83610

else if ($str[$position] == "\r" && $str[$position] == "\n") {

else  if ($str[$position] == "\r" && $str[$position] == "\n") {
                            $position += 2;
                        }

$str[$position] can't be equal to "\r" and "\n" at the same time.

if ($str[$position] == "\n") is checked earlier so we think that code should be like:

else  if ($str[$position] == "\r" && $str[$position + 1] == "\n") {
                            $position += 2;
                        }

Possible defect was found by Echelon Team with AppChecker static analyzer

[alecpl]

Thanks. Fixed.