Fix possible defect in handling \r\n in scripts (#5685)

roundcube · Mar 9, 2017 · 33586e4 · 33586e4
1 parent 85a750a
commit 33586e4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -23,6 +23,7 @@ RELEASE 1.2.4
 - Add rewrite rule to disable access to /vendor/bin folder in .htaccess (#5630)
 - Fix bug where it was too easy accidentally move a folder when using the subscription checkbox (#5655)
 - Managesieve: Fix parser issue with empty lines between comments (#5657)
+- Managesieve: Fix possible defect in handling \r\n in scripts (#5685)
 
 RELEASE 1.2.3
 -------------

diff --git a/plugins/managesieve/Changelog b/plugins/managesieve/Changelog
@@ -1,4 +1,5 @@
 - Fix handling of scripts with nested rules (#5540)
+- Fix possible defect in handling \r\n in scripts (#5685)
 
 * version 8.6 [2016-04-06]
 -----------------------------------------------------------

diff --git a/plugins/managesieve/lib/Roundcube/rcube_sieve_script.php b/plugins/managesieve/lib/Roundcube/rcube_sieve_script.php
@@ -1215,7 +1215,7 @@ static function tokenize($str, $num = 0, &$position = 0)
                         if ($str[$position] == "\n") {
                             $position++;
                         }
-                        else if ($str[$position] == "\r" && $str[$position] == "\n") {
+                        else if ($str[$position] == "\r" && $str[$position + 1] == "\n") {
                             $position += 2;
                         }