Skip to content

Commit

Permalink
Fix missing cursor in HTML editor on mail reply (#5969)
Browse files Browse the repository at this point in the history
  • Loading branch information
alecpl committed Sep 29, 2017
1 parent 5660489 commit 79ea526
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ CHANGELOG Roundcube Webmail
- Fix bug where HTML messages could have been rendered empty on some systems (#5957)
- Fix wording of "Mark previewed messages as read" to "Mark messages as read" (#5952)
- Enigma: Fix decryption of messages encoded with non-ascii charset (#5962)
- Fix missing cursor in HTML editor on mail reply (#5969)

RELEASE 1.3.1
-------------
Expand Down
11 changes: 6 additions & 5 deletions program/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -4276,9 +4276,7 @@ function rcube_webmail()
else if (input_message)
elem = input_message;

this.init_messageform_inputs(elem);

this.env.compose_focus_elem = document.activeElement;
this.env.compose_focus_elem = this.init_messageform_inputs(elem);

// get summary of all field values
this.compose_field_hash(true);
Expand Down Expand Up @@ -4308,8 +4306,11 @@ function rcube_webmail()
this.init_address_input_events($("[name='_"+ac_fields[i]+"']"), ac_props);
}

// focus first empty element
$(focused || input_to).focus();
if (!focused)
focused = input_to;

// focus first empty element (and return it)
return $(focused).focus().get(0);
};

this.compose_restore_dialog = function(j, html_mode)
Expand Down
2 changes: 1 addition & 1 deletion program/js/editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ function rcube_text_editor(config, id)
rcmail.change_identity(elem);

// Focus previously focused element
if (fe && fe.id != this.id) {
if (fe && fe.id != this.id && fe.nodeName != 'BODY') {
window.focus(); // for WebKit (#1486674)
fe.focus();
rcmail.env.compose_focus_elem = null;
Expand Down

0 comments on commit 79ea526

Please sign in to comment.