Fix bug where contacts search could skip some records (#6130)

Conflicts: CHANGELOG
roundcube · Jan 10, 2018 · 2eeb2c7 · 2eeb2c7
1 parent 917ae1c
commit 2eeb2c7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,6 +1,8 @@
 CHANGELOG Roundcube Webmail
 ===========================
 
+- Fix bug where contacts search could skip some records (#6130)
+
 RELEASE 1.3.4
 -------------
 - Fix a couple of warnings on PHP 7.2 (#6098)

diff --git a/program/lib/Roundcube/rcube_addressbook.php b/program/lib/Roundcube/rcube_addressbook.php
@@ -654,13 +654,16 @@ public static function compose_search_name($contact, $email = null, $name = null
      */
     public static function compose_contact_key($contact, $sort_col)
     {
-        $key = $contact[$sort_col] . ':' . $contact['sourceid'];
+        $key = $contact[$sort_col];
 
         // add email to a key to not skip contacts with the same name (#1488375)
         if (($email = self::get_col_values('email', $contact, true)) && !empty($email)) {
             $key .= ':' . implode(':', (array)$email);
         }
 
+        // Make the key really unique (as we e.g. support contacts with no email)
+        $key .= ':' . $contact['sourceid'] . ':' . $contact['ID'];
+
         return $key;
     }