Skip to content

Commit

Permalink
Fix issue caused by non-default session.cookie_lifetime setting (#5961)
Browse files Browse the repository at this point in the history
  • Loading branch information
alecpl committed Oct 9, 2017
1 parent b07a5e5 commit 1bb9797
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ CHANGELOG Roundcube Webmail
- Fix bug where mail search could return empty result on servers without SORT capability (#5973)
- Fix bug where assets_path wasn't added to some watermark frames
- Fix so untagged COPYUID responses are also supported according to RFC6851 (#5982)
- Fix issue caused by non-default session.cookie_lifetime setting (#5961)

RELEASE 1.3.1
-------------
Expand Down
2 changes: 2 additions & 0 deletions program/lib/Roundcube/rcube.php
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,8 @@ public function session_init()
ini_set('session.gc_maxlifetime', $lifetime * 2);
}

// set session cookie lifetime so it never expires (#5961)

This comment has been minimized.

Copy link
@mkllnk

mkllnk Mar 31, 2018

Contributor

This is not true. According to the PHP session cookie lifetime documentation a value of 0 means that the cookie is deleted when the browser is closed. There is no way to set cookies to "never expire". You can just give them a very far expiry date.

I guess this is related to #5050.

ini_set('session.cookie_lifetime', 0);
ini_set('session.cookie_secure', $is_secure);
ini_set('session.name', $sess_name ?: 'roundcube_sessid');
ini_set('session.use_cookies', 1);
Expand Down

0 comments on commit 1bb9797

Please sign in to comment.